fix: use cesrnumber when parsing sn in rotate event #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 46 46
Lines 4218 4218
Branches 1053 1029 -24
=======================================
Hits 3491 3491
- Misses 698 722 +24
+ Partials 29 5 -24 ☔ View full report in Codecov by Sentry. |
rodolfomiranda
approved these changes
May 2, 2024
|
Accidentally deleted the branch on my fork. Did not intend to close the PR. |
lenkan
force-pushed
the
fix-number-constructor
branch
from
404c377
to
97e071e
Compare
rodolfomiranda
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it does the same as the "interact" function. See
signify-ts/src/keri/core/eventing.ts
Lines 533 to 537 in fddaff2
Closes #220
Also related #138